Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CREATE ROLE role1 error #12341

Merged
merged 7 commits into from Aug 9, 2023

Conversation

parkma99
Copy link
Contributor

@parkma99 parkma99 commented Aug 3, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

replace the String token into an Identifier token in create_role


This change is Reviewable

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 10:19am

@parkma99 parkma99 marked this pull request as ready for review August 3, 2023 05:59
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Aug 3, 2023
@parkma99 parkma99 force-pushed the fix/CREATE_ROLE_role1_error branch from 75a444b to 09ae1bc Compare August 3, 2023 05:59
@BohuTANG
Copy link
Member

BohuTANG commented Aug 5, 2023

Great, but we need a logic test for this changed.

@parkma99
Copy link
Contributor Author

parkma99 commented Aug 7, 2023

Thanks, Now I am at home this week, I will go to office next week.

@TCeason TCeason force-pushed the fix/CREATE_ROLE_role1_error branch from 781f9c8 to 4e73cea Compare August 9, 2023 05:42
@vercel
Copy link

vercel bot commented Aug 9, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

src/query/ast/src/parser/statement.rs Outdated Show resolved Hide resolved
src/query/ast/tests/it/parser.rs Show resolved Hide resolved
@TCeason TCeason force-pushed the fix/CREATE_ROLE_role1_error branch from 9764a48 to bf1a61b Compare August 9, 2023 10:19
@BohuTANG BohuTANG merged commit ad11c9e into datafuselabs:main Aug 9, 2023
54 checks passed
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* fix: CREATE ROLE role1 error

* fix

* Update 05_0014_ddl_create_role

* Update 05_0014_ddl_create_role

* role_name replace to ident

* fix test

* fix conversation && Compatible with previous parse

---------

Co-authored-by: BohuTANG <overred.shuttler@gmail.com>
Co-authored-by: taichong <tai_chong@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: CREATE ROLE role1 error
4 participants