New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CREATE ROLE role1 error #12341
Merged
BohuTANG
merged 7 commits into
datafuselabs:main
from
parkma99:fix/CREATE_ROLE_role1_error
Aug 9, 2023
Merged
fix: CREATE ROLE role1 error #12341
BohuTANG
merged 7 commits into
datafuselabs:main
from
parkma99:fix/CREATE_ROLE_role1_error
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
parkma99
force-pushed
the
fix/CREATE_ROLE_role1_error
branch
from
August 3, 2023 05:59
75a444b
to
09ae1bc
Compare
Great, but we need a logic test for this changed. |
Thanks, Now I am at home this week, I will go to office next week. |
BohuTANG
reviewed
Aug 8, 2023
TCeason
force-pushed
the
fix/CREATE_ROLE_role1_error
branch
from
August 9, 2023 05:42
781f9c8
to
4e73cea
Compare
Deployment failed with the following error:
|
xudong963
reviewed
Aug 9, 2023
TCeason
force-pushed
the
fix/CREATE_ROLE_role1_error
branch
from
August 9, 2023 10:19
9764a48
to
bf1a61b
Compare
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
* fix: CREATE ROLE role1 error * fix * Update 05_0014_ddl_create_role * Update 05_0014_ddl_create_role * role_name replace to ident * fix test * fix conversation && Compatible with previous parse --------- Co-authored-by: BohuTANG <overred.shuttler@gmail.com> Co-authored-by: taichong <tai_chong@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
replace the String token into an Identifier token in
create_role
This change is