Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): mysql handler tls support #12353

Merged
merged 2 commits into from Aug 6, 2023

Conversation

akoshchiy
Copy link
Contributor

@akoshchiy akoshchiy commented Aug 3, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR


This change is Reviewable

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2023 0:52am

@akoshchiy
Copy link
Contributor Author

  1. There is no client authentication, is it enough or it's better to add it? As I understood, client auth also requires "no password" login as mysql does.
  2. Seems that ci-run-stateless-tests-cluster-tls.sh is not using in CI check now. Should I create my own tests with mysql client? Added some integration test in mysql_handler.rs, but I think it's also a good idea to test with the mysql client with enabled tls mode.

@akoshchiy akoshchiy marked this pull request as ready for review August 5, 2023 07:06
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 5, 2023
@zhang2014
Copy link
Member

zhang2014 commented Aug 6, 2023

Thanks for your contribution

  1. There is no client authentication, is it enough or it's better to add it? As I understood, c also requires "no password" login as mysql does.

databend don't supported specifying host after #11771. BTW: no password login is disabled by default in databend

  1. Seems that ci-run-stateless-tests-cluster-tls.sh is not using in CI check now. Should I create my own tests with mysql client? Added some integration test in mysql_handler.rs, but I think it's also a good idea to test with the mysql client with enabled tls mode.

integration test is Ok.

@zhang2014 zhang2014 merged commit 18be8a2 into datafuselabs:main Aug 6, 2023
55 checks passed
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Co-authored-by: Winter Zhang <coswde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: tls support for mysql handler
2 participants