Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add storage params in hive catalog #12469

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 15, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix #12407


This change is Reviewable

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2023 3:21pm

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Aug 15, 2023
@Xuanwo Xuanwo requested review from everpcpc and PsiACE August 15, 2023 06:09
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @everpcpc and @PsiACE)

@Xuanwo Xuanwo merged commit ac2e70f into datafuselabs:main Aug 15, 2023
55 of 56 checks passed
@Xuanwo Xuanwo deleted the hive-connection branch August 15, 2023 17:55
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add storage support for Hive catalog
3 participants