Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: assert that pushdown columns must exist #13228

Merged
merged 17 commits into from Dec 7, 2023
Merged

chore: assert that pushdown columns must exist #13228

merged 17 commits into from Dec 7, 2023

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Oct 12, 2023 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  • Closes #issue

This change is Reviewable

@vercel
Copy link

vercel bot commented Oct 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 1:28pm

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 12, 2023
@sundy-li
Copy link
Member

sundy-li commented Dec 5, 2023 •
edited

There will be some inner columns, like SELECT a,_row_id FROM 05_0031_t where _row_id = 18446735277616529408

@andylokandy andylokandy marked this pull request as draft December 6, 2023 05:41
@andylokandy andylokandy marked this pull request as ready for review December 7, 2023 13:24
@andylokandy andylokandy added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@andylokandy andylokandy added this pull request to the merge queue Dec 7, 2023
Merged via the queue into datafuselabs:main with commit e9934ab Dec 7, 2023
70 checks passed
@andylokandy andylokandy deleted the pushdown branch December 7, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh Awaiting requested review from b41sh

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andylokandy @sundy-li