chore: add current_timestamp function #13751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
TCeason
reviewed
Nov 17, 2023
|
CI failed https://github.com/datafuselabs/databend/actions/runs/6899767394/job/18772060466?pr=13751 [SQL] create table db2.test6(id Int8, created timestamp DEFAULT CURRENT_TIMESTAMP) Error: SelfError("sqllogictest failed") |
|
Will literal And we could add test for select CURRENT_TIMESTAMP; -- not supported yet
select CURRENT_TIMESTAMP(); |
sundy-li
reviewed
Nov 18, 2023
sundy-li
approved these changes
Nov 23, 2023
sundy-li
reviewed
Nov 23, 2023
andylokandy
reviewed
Nov 23, 2023
andylokandy
reviewed
Nov 23, 2023
| Literal::CurrentTimestamp => Err(ErrorCode::SemanticError(format!( | ||
| "Unsupported literal value: {literal}" | ||
| )))?, | ||
| Literal::CurrentTimestamp => Scalar::Timestamp(Local::now().timestamp_micros()), |
There was a problem hiding this comment.
Suggested change
| Literal::CurrentTimestamp => Scalar::Timestamp(Local::now().timestamp_micros()), | |
| Literal::CurrentTimestamp => self.resolve_function(*span, "CURRENT_TIMESTAMP", vec![], vec![]) | |
| .await |
There was a problem hiding this comment.
resolve_function is an async function.
There was a problem hiding this comment.
resolve_scalar_function_call could change to be sync function.
andylokandy
approved these changes
Nov 23, 2023
TCeason
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
chore: add current_timestamp function
This change is