Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change default value of use_parquet2 to 0. #13754

Merged
merged 2 commits into from
Nov 23, 2023
Merged

feat: change default value of use_parquet2 to 0. #13754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3c0a9f
feat: change default value of use_parquet2 to 0.
youngsofun Nov 17, 2023
a2b9962
Merge branch 'main' into parquet2
youngsofun Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/query/service/tests/it/storages/testdata/settings_table.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ DB.Table: 'system'.'settings', Table: settings-table_id:1, ver:0, Engine: System
| 'table_lock_expire_secs' | '10' | '10' | 'SESSION' | 'Sets the seconds that the table lock will expire in.' | 'UInt64' |
| 'timezone' | 'UTC' | 'UTC' | 'SESSION' | 'Sets the timezone.' | 'String' |
| 'unquoted_ident_case_sensitive' | '0' | '0' | 'SESSION' | 'Determines whether Databend treats unquoted identifiers as case-sensitive.' | 'UInt64' |
| 'use_parquet2' | '1' | '1' | 'SESSION' | 'Use parquet2 instead of parquet_rs when infer_schema().' | 'UInt64' |
| 'use_parquet2' | '0' | '0' | 'SESSION' | 'Use parquet2 instead of parquet_rs when infer_schema().' | 'UInt64' |
+------------------------------------------------+----------------+----------------+-----------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+


2 changes: 1 addition & 1 deletion src/query/settings/src/settings_default.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ impl DefaultSettings {
display_in_show_settings: true,
}),
("use_parquet2", DefaultSettingValue {
value: UserSettingValue::UInt64(1),
value: UserSettingValue::UInt64(0),
BohuTANG marked this conversation as resolved.
Show resolved Hide resolved
desc: "Use parquet2 instead of parquet_rs when infer_schema().",
possible_values: None,
display_in_show_settings: true,
Expand Down