Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): use warnings in system.tables on bad remote databases #13834

Merged
merged 3 commits into from Nov 28, 2023

Conversation

flaneur2020
Copy link
Member

@flaneur2020 flaneur2020 commented Nov 28, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

this PR is related with #13413 , we can seperate in another PR to add the warnings field in the HTTP query protocol.


This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 28, 2023
@flaneur2020 flaneur2020 changed the title fix: use warnings in system.tables on bad remote databases fix(system.tables): use warnings in system.tables on bad remote databases Nov 28, 2023
@flaneur2020 flaneur2020 marked this pull request as ready for review November 28, 2023 10:33
Copy link
Contributor

This pull request's title is not fulfill the requirements. @flaneur2020 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

1 similar comment
Copy link
Contributor

This pull request's title is not fulfill the requirements. @flaneur2020 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: rfc, feat, fix, refactor, ci, docs, chore

Valid types:

  • rfc: this PR proposes a new RFC
  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci: this PR changes build/testing/ci steps
  • docs: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@flaneur2020 flaneur2020 changed the title fix(system.tables): use warnings in system.tables on bad remote databases fix(query): use warnings in system.tables on bad remote databases Nov 28, 2023
@BohuTANG BohuTANG merged commit c3583c9 into datafuselabs:main Nov 28, 2023
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants