Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add visit for merge into/update/replace/insert/delete/copy statement #13848

Merged
merged 44 commits into from Dec 1, 2023
Merged

fix: add visit for merge into/update/replace/insert/delete/copy statement #13848

merged 44 commits into from Dec 1, 2023

Conversation

JackTan25
Copy link
Collaborator

@JackTan25 JackTan25 commented Nov 29, 2023 •
edited

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. we need to add visit query for merge into/copy/insert/delete/update/replace, because there are some rewrite rules for it.
  2. add scalar_expr check for source data in (merge, insert,copy,replace)
    • 2.1 copy into location source doesn't support window,udf function, aggragate
    • 2.2 merge/insert/repalce source doesn't support udf function.
      Summary about this PR

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 29, 2023
@JackTan25 JackTan25 changed the title fix: try to assure aggragate optimize problem fix: try to assure aggragate optimize problem (just for test) Nov 29, 2023
@JackTan25 JackTan25 changed the title fix: try to assure aggragate optimize problem (just for test) fix: add visit query for merge into statement Nov 29, 2023
@JackTan25 JackTan25 added the ci-cloud Build docker image for cloud test label Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13848-1170c27

note: this image tag is only available for internal use,
please check the internal doc for more details.

@JackTan25 JackTan25 mentioned this pull request Nov 29, 2023
Closed
@JackTan25 JackTan25 marked this pull request as ready for review November 29, 2023 07:53
@JackTan25 JackTan25 requested a review from b41sh November 29, 2023 10:05
BohuTANG
BohuTANG approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, wizard merge into passed.

@JackTan25 JackTan25 requested a review from b41sh November 29, 2023 11:43
@JackTan25
Copy link
Collaborator Author

cc @BohuTANG seems the python build is non business of this pr, can we merge?

@BohuTANG BohuTANG requested a review from b41sh November 30, 2023 01:07
@JackTan25 JackTan25 marked this pull request as ready for review December 1, 2023 10:17
@JackTan25 JackTan25 added this pull request to the merge queue Dec 1, 2023
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 1, 2023
@BohuTANG BohuTANG merged commit e5db3a9 into datafuselabs:main Dec 1, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@b41sh b41sh b41sh approved these changes

@ariesdevil ariesdevil ariesdevil approved these changes

@dantengsky dantengsky dantengsky approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JackTan25 @sundy-li @BohuTANG @b41sh @youngsofun @ariesdevil @dantengsky