Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto enable change tracking when create stream #13858

Merged
merged 1 commit into from Nov 30, 2023

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Nov 29, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Auto enable change tracking when create stream.

mysql> create table t(a int);
Query OK, 0 rows affected (0.11 sec)

mysql> insert into t values(1);
Query OK, 1 row affected (0.21 sec)

mysql> create stream s on table t;
Query OK, 0 rows affected (0.17 sec)

mysql> set hide_options_in_show_create_table=0;
Query OK, 0 rows affected (0.03 sec)

mysql> show create table t;
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                                                                                                             |
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| t     | CREATE TABLE `t` (
  `a` INT NULL
) ENGINE=FUSE CHANGE_TRACKING='true' COMPRESSION='zstd' SNAPSHOT_LOCATION='1/843/_ss/1c8a3f78bcee4104bbb10c252365d3d2_v4.mpk' STORAGE_FORMAT='parquet' |
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.14 sec)
Read 0 rows, 0.00 B in 0.044 sec., 0 rows/sec., 0.00 B/sec.
  • Closes #issue

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 29, 2023
@BohuTANG BohuTANG merged commit d04021a into datafuselabs:main Nov 30, 2023
68 checks passed
@BohuTANG
Copy link
Member

We can remove the enable change tracking part before create stream now cc @soyeric128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants