Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: push down sort pipeline to cluster nodes. #13881

Merged
merged 8 commits into from Dec 5, 2023

Conversation

RinChanNOWWW
Copy link
Member

@RinChanNOWWW RinChanNOWWW commented Nov 30, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Push down sort pipeline to cluster nodes.

Cluster nodes build the full sort pipeline: SortPartialTransform -> SortMergeTransform -> MultiSortMergeTransform.
Coordinator node only builds MultiSortMergeTransform.

distributed_sort_pipeline drawio

P.S. If the max_threads of the coordinator is 1, the MultiSortMergeTranform will degenerate to a SortMergeTransform.

Tracking in #13889


This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 30, 2023
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review December 3, 2023 04:47
@RinChanNOWWW RinChanNOWWW marked this pull request as draft December 4, 2023 02:52
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review December 4, 2023 03:58
@RinChanNOWWW RinChanNOWWW marked this pull request as draft December 4, 2023 06:52
@RinChanNOWWW
Copy link
Member Author

Wait for #13909 .

@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review December 4, 2023 10:43
@sundy-li sundy-li added this pull request to the merge queue Dec 5, 2023
Merged via the queue into datafuselabs:main with commit ed2e2f2 Dec 5, 2023
70 checks passed
@RinChanNOWWW RinChanNOWWW deleted the distributed-sort branch December 5, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants