Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support connection in stage related infer_schema #13890

Merged
merged 6 commits into from Dec 4, 2023

Conversation

guojidan
Copy link
Contributor

@guojidan guojidan commented Dec 1, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR
support infer_schema(location => <uri>, connection_name => <connection_name>)


This change is Reviewable

@guojidan guojidan changed the title support connection in stage related infer_schema feat: support connection in stage related infer_schema Dec 1, 2023
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 1, 2023
@BohuTANG
Copy link
Member

BohuTANG commented Dec 1, 2023

@guojidan 👍
It's better to add some tests(unit test or logic tests):

  1. make sure this PR works as expected
  2. avoid someone break your code logic in future

@guojidan
Copy link
Contributor Author

guojidan commented Dec 1, 2023

@guojidan 👍 It's better to add some tests(unit test or logic tests):

  1. make sure this PR works as expected
  2. avoid someone break your code logic in future

ok, this pr is WIP

@guojidan guojidan marked this pull request as draft December 1, 2023 03:40
@guojidan guojidan marked this pull request as ready for review December 4, 2023 06:58
@guojidan
Copy link
Contributor Author

guojidan commented Dec 4, 2023

please review this pr @youngsofun

@BohuTANG BohuTANG merged commit 35fec84 into datafuselabs:main Dec 4, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support connection in stage related table functions
3 participants