Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add json_path_match & @?,@@ operators #13906

Merged
merged 2 commits into from Dec 4, 2023
Merged

feat: add json_path_match & @?,@@ operators #13906

merged 2 commits into from Dec 4, 2023

Conversation

akoshchiy
Copy link
Contributor

@akoshchiy akoshchiy commented Dec 3, 2023 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. Added json_path_match, @?, @@;
  2. Refactored json_path_exists implementation to factory function (optimisation for scalar jsonpath);

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 3, 2023
@akoshchiy akoshchiy marked this pull request as ready for review December 3, 2023 18:54
@sundy-li sundy-li requested a review from b41sh December 4, 2023 00:49
b41sh
b41sh approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution @akoshchiy

@b41sh b41sh added this pull request to the merge queue Dec 4, 2023
Merged via the queue into datafuselabs:main with commit 3a78bd5 Dec 4, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akoshchiy @b41sh