Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move crates deps to the root Cargo.toml #13969

Merged
merged 2 commits into from Dec 10, 2023
Merged

chore: move crates deps to the root Cargo.toml #13969

merged 2 commits into from Dec 10, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 10, 2023 •
edited

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • no deps version bump
  • only move the deps to root cargo.toml if they are used in many crates
  • easy to maintain
  • Closes #issue

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 10, 2023
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Dec 10, 2023
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-13969-c629603

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG marked this pull request as ready for review December 10, 2023 13:02
@github-actions GitHub Actions
Copy link
Contributor

cloud cloud

ClickBench Report

@BohuTANG BohuTANG merged commit ed0c3f8 into datafuselabs:main Dec 10, 2023
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@BohuTANG