refactor: refactor error message return for drop table and set options

[JackTan25]

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

There are bad code written by before unexpectedly. We should process the error correctly. For alter option and drop table, when they can't get table, if the error is not unknown table, we should return the true error message,

mysql> show tables;
Empty set (0.21 sec)
Read 0 rows, 0.00 B in 0.042 sec., 0 rows/sec., 0.00 B/sec.

mysql> drop table t1;
ERROR 1105 (HY000): UnknownTable. Code: 1025, Text = Unknown table `default`.`t1` in catalog 'default'.
mysql> drop table if exists t1;
Query OK, 0 rows affected (0.01 sec)

mysql> alter table t1 set options(block_per_segment = 500);
ERROR 1105 (HY000): UnknownTable. Code: 1025, Text = Unknown table `default`.`t1` in catalog 'default'.
## close databend-meta
mysql> drop table if exists t1;
ERROR 1105 (HY000): MetaServiceError. Code: 2001, Text = failed to handshake with meta-service: when sending handshake rpc, cause: tonic::status::Status: status: Unavailable, message: "error trying to connect: tcp connect error: Connection refused (os error 61)", details: [], metadata: MetadataMap { headers: {} } source: transport error source: error trying to connect: tcp connect error: Connection refused (os error 61) source: tcp connect error: Connection refused (os error 61) source: Connection refused (os error 61)
(while
mysql> drop table t1;
ERROR 1105 (HY000): MetaServiceError. Code: 2001, Text = failed to handshake with meta-service: when sending handshake rpc, cause: tonic::status::Status: status: Unavailable, message: "error trying to connect: tcp connect error: Connection refused (os error 61)", details: [], metadata: MetadataMap { headers: {} } source: transport error source: error trying to connect: tcp connect error: Connection refused (os error 61) source: tcp connect error: Connection refused (os error 61) source: Connection refused (os error 61)
(while
mysql> alter table t1 set options(block_per_segment = 500);
ERROR 1105 (HY000): MetaServiceError. Code: 2001, Text = failed to handshake with meta-service: when sending handshake rpc, cause: tonic::status::Status: status: Unavailable, message: "error trying to connect: tcp connect error: Connection refused (os error 61)", details: [], metadata: MetadataMap { headers: {} } source: transport error source: error trying to connect: tcp connect error: Connection refused (os error 61) source: tcp connect error: Connection refused (os error 61) source: Connection refused (os error 61)
(while

Fixes #[Link the issue here]
#14072 #14071

Tests

• Unit Test
• Logic Test
• Benchmark Test
• No Test - just refactor little code

Type of change

• Bug Fix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that could cause existing functionality not to work as expected)
• Documentation Update
• Refactoring
• Performance Improvement
• Other (please describe):

---

This change is 

[drmingdrmer]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dantengsky and @JackTan25)

---

src/query/service/src/interpreters/interpreter_table_drop.rs line 61 at r1 (raw file):

            Err(error) => {
                // UnknownTable Code
                if error.code() == 1025 {

Do not use integer literal, use a named const or something people understand

[drmingdrmer]

Reviewed 2 of 4 files at r4, all commit messages.
Reviewable status: 2 of 8 files reviewed, 5 unresolved discussions (waiting on @dantengsky, @JackTan25, and @ZhiHanZ)

---

src/query/service/src/interpreters/interpreter_table_drop.rs line 62 at r4 (raw file):

                if (error.code() == ErrorCode::UNKNOWN_TABLE
                    || error.code() == ErrorCode::UNKNOWN_CATALOG
                    || error.code() == ErrorCode::UNKNOWN_DATABASE)

get_table() also returns business errors such as: WrongShare, WrongShareObject, UnknownTableId. These errors should be caught too.

databend/src/meta/api/src/schema_api_impl.rs

Line 4119 in 188426e

return Err(KVAppError::AppError(AppError::WrongShare(WrongShare::new(

databend/src/meta/api/src/schema_api_impl.rs

Line 4135 in 188426e

WrongShareObject::new(table_name.to_string_key()),

databend/src/meta/api/src/util.rs

Line 778 in 188426e

UnknownTableId::new(*id, "get_table_names_by_ids"),

[JackTan25]

please see https://github.com/datafuselabs/databend/pull/14078/files#diff-4bba49bb358f77b13cd8e8f9fb64f654d0112ff6c0ba5f5b2bfb72d498cc99afR67 @drmingdrmer

[drmingdrmer]

please see https://github.com/datafuselabs/databend/pull/14078/files#diff-4bba49bb358f77b13cd8e8f9fb64f654d0112ff6c0ba5f5b2bfb72d498cc99afR67 @drmingdrmer

I see. What should I be concerned about? 🤔

[JackTan25]

please see https://github.com/datafuselabs/databend/pull/14078/files#diff-4bba49bb358f77b13cd8e8f9fb64f654d0112ff6c0ba5f5b2bfb72d498cc99afR67 @drmingdrmer

I see. What should I be concerned about? 🤔

I just express that we can return the error to fronted end.

[drmingdrmer]

please see https://github.com/datafuselabs/databend/pull/14078/files#diff-4bba49bb358f77b13cd8e8f9fb64f654d0112ff6c0ba5f5b2bfb72d498cc99afR67 @drmingdrmer

I see. What should I be concerned about? 🤔

I just express that we can return the error to fronted end.

You caught these 3 errors:

 if (error.code() == ErrorCode::UNKNOWN_TABLE
                    || error.code() == ErrorCode::UNKNOWN_CATALOG
                    || error.code() == ErrorCode::UNKNOWN_DATABASE)

But get_table() will also returns : WrongShare, WrongShareObject, UnknownTableId errors.

Why do you have to deal with UNKNOWN_TABLE, UNKNOWN_CATALOG and UNKNOWN_DATABASE but do not deal with the former three?