Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lychee links checker with cache #14100

Merged
merged 3 commits into from Dec 21, 2023
Merged

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Dec 20, 2023

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • add lychee as a links checker with cache
  • fix broken links

Fixes #14094

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - github workflow, cron: "00 18 * * *"

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): ci: add links checker

This change is Reviewable

Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
@github-actions github-actions bot added the pr-build this PR changes build/testing/ci steps label Dec 20, 2023
Signed-off-by: Chojan Shang <psiace@apache.org>
@BohuTANG
Copy link
Member

It's weird modified the *.md files but all the CI will run :/ , should we improve it?

@PsiACE
Copy link
Member Author

PsiACE commented Dec 21, 2023

It's weird modified the *.md files but all the CI will run :/ , should we improve it?

Yes, we need to skip some files to avoid unnecessary resource waste.

@PsiACE PsiACE added this pull request to the merge queue Dec 21, 2023
Merged via the queue into datafuselabs:main with commit 6b67bf5 Dec 21, 2023
68 checks passed
@PsiACE PsiACE deleted the lychee branch December 21, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ci tool to detect the broken link
3 participants