Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more comments for auto compact and remove the settings table goldenfile test #14101

Merged
merged 1 commit into from Dec 21, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 21, 2023

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • add more comments for fuse compact
  • refine the desciption for auto_compaction_threshold setting
  • remove test_settings_table unit test, this is not useful, we need to generate it again and again if we modify the settings, waste time :)

Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Existing tests cover.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 21, 2023
@BohuTANG BohuTANG marked this pull request as ready for review December 21, 2023 02:03
@BohuTANG
Copy link
Member Author

Dev / linux / sqllogic / cluster (base, mysql) (pull_request) is not related to this PR, it's a flaky test.

@BohuTANG BohuTANG merged commit da8a419 into datafuselabs:main Dec 21, 2023
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants