Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the compact hook warn message and rename auto_compaction_threshold to auto_compaction_imperfect_blocks_threshold #14117

Merged
merged 3 commits into from Dec 21, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 21, 2023

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • remove warn log from hook_compact, this maybe flood
  • auto_compaction_threshold -> auto_compaction_imperfect_blocks_threshold, make it more meaningful
  • collapsed hook_compact setting checks

Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 21, 2023
@BohuTANG BohuTANG requested a review from zhyass December 21, 2023 14:41
@BohuTANG BohuTANG marked this pull request as ready for review December 21, 2023 14:46
@BohuTANG BohuTANG changed the title chore: remove the compact hook warn message chore: remove the compact hook warn message and rename auto_compaction_threshold to auto_compaction_imperfect_blocks_threshold Dec 21, 2023
@BohuTANG BohuTANG merged commit 05abecf into datafuselabs:main Dec 21, 2023
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants