refactor: move to meta-service handshake into pool #14161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
49-refine-pool
branch
3 times, most recently
from
e06929b
to
f32a09b
Compare
drmingdrmer
commented
Dec 27, 2023
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer)
drmingdrmer
force-pushed
the
49-refine-pool
branch
4 times, most recently
from
9f91fb2
to
7686640
Compare
drmingdrmer
commented
Dec 27, 2023
There was a problem hiding this comment.
Reviewed 7 of 9 files at r3, 1 of 1 files at r4, 2 of 2 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status:
Before this commit the connection pool stores raw connections `Channel`. Before using one, the client handshake with the server everytime using a channel. In this commit, the handshake is moved into the connection pool and the pool stores `MetaServiceClient` that already finished the handshake phase. Thus the client no longer needs to send a handshake RPC before using an in-pool connection. Other changes: - Add meta gRPC client re-connect test - Add: EstablishedClient, when handshake expire, drop the client and create a new one.
drmingdrmer
force-pushed
the
49-refine-pool
branch
from
7686640
to
0ffd79c
Compare
drmingdrmer
changed the title
ariesdevil
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: move to meta-service handshake into poll
Before this commit the connection pool stores raw connections
Channel.Before using one, the client handshake with the server everytime using a
channel.
In this commit, the handshake is moved into the connection pool and the
pool stores
MetaServiceClientthat already finished the handshakephase.
Thus the client no longer needs to send a handshake RPC before using an
in-pool connection.
Changelog
Related Issues
This change is