fix: trim block metas pruned by runtime filter #14166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantengsky
force-pushed
the
fix-trim-block-metas-pruned-by-runtime-filter
branch
from
fc4aab7
to
a972da6
Compare
so that the number of PartInfoPtr and DataSource passed to downstream will be equal to each other
dantengsky
force-pushed
the
fix-trim-block-metas-pruned-by-runtime-filter
branch
from
a972da6
to
b4abd56
Compare
xudong963
reviewed
Dec 27, 2023
xudong963
approved these changes
Dec 27, 2023
run sql logic test dir "query" with - mysql and http hanlders - minio as backend storage
dantengsky
force-pushed
the
fix-trim-block-metas-pruned-by-runtime-filter
branch
from
01e6278
to
26347a5
Compare
everpcpc
approved these changes
Dec 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
When
ReadParquetDataSourceandReadParquetDataSourcefunctioning as an async processor, it may incorrectly pass block metadata that was pruned by the runtime filter downstream.addressed by commit b4abd56 of this PR, accompanied by the SQL logic test case in commit 28cd2d2.
The error message for de-serialization failures has been modified to include the location and column information.
A minor refactor that eliminates duplicate code of
native|parquet_data_source.rsadd new ci job "standalone-minio", which runs sql logic test dir "query" with
since the issue addressed in this PR occurs only when s3 (non-blocking io) style storage is used
please see commit 26347a5
Fixes #14165
Tests
Type of change
This change is