Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable distributed execution of merge-into when spilling is enabled #14178

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Dec 28, 2023

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

on behalf of @JackTan25 :

Distributed execution of merge-into is not ready to go with join-spilling yet, thus let's disable distributed execution of merge-into when spilling is enabled.

Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - no extra tests needed

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 28, 2023
@dantengsky dantengsky force-pushed the chore-disable-dist-merge-into-when-spilling branch from f726ad4 to 558f009 Compare December 28, 2023 02:09
@dantengsky dantengsky marked this pull request as ready for review January 3, 2024 01:55
@dantengsky dantengsky added this pull request to the merge queue Jan 3, 2024
Merged via the queue into datafuselabs:main with commit 61c8181 Jan 3, 2024
73 checks passed
@dantengsky dantengsky deleted the chore-disable-dist-merge-into-when-spilling branch January 3, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants