Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the hook #14250

Merged
merged 1 commit into from Jan 6, 2024
Merged

chore: refactor the hook #14250

merged 1 commit into from Jan 6, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Jan 6, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • add enable_refresh_aggregating_index_after_write setting
  • add HookOperator to make the hook execute more simple:
let hook_operator = HookOperator::create(...);
hook_operator.execute().await; -- execute compact and refresh hook
hook_operator.execute_compact().await; 
hook_operator.execute_refresh().await; 

Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Only refactor, origin tests covered

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 6, 2024
@BohuTANG BohuTANG marked this pull request as ready for review January 6, 2024 12:26
@BohuTANG BohuTANG merged commit 4d4ad76 into datafuselabs:main Jan 6, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant