Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add json concat #14251

Merged
merged 2 commits into from Jan 8, 2024
Merged

feat: add json concat #14251

merged 2 commits into from Jan 8, 2024

Conversation

akoshchiy
Copy link
Contributor

@akoshchiy akoshchiy commented Jan 6, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Added || json operator.

Related #11270

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 6, 2024
@b41sh b41sh self-requested a review January 7, 2024 03:58
@akoshchiy
Copy link
Contributor Author

Merge for datafuselabs/jsonb#43 is required.

@akoshchiy akoshchiy marked this pull request as ready for review January 7, 2024 17:39
b41sh
b41sh approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution @akoshchiy

@b41sh b41sh added this pull request to the merge queue Jan 8, 2024
Merged via the queue into datafuselabs:main with commit d3e9648 Jan 8, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akoshchiy @b41sh