Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): remove codes of storage/parquet2 #14305

Merged
merged 4 commits into from Feb 29, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 11, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Remove codes of storage/parquet2, and make setting use_parquet2 deprecated. Let's always use parquet-rs cause it's stable.

Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 11, 2024
@sundy-li sundy-li requested a review from b41sh January 11, 2024 14:00
@BohuTANG BohuTANG marked this pull request as draft January 12, 2024 07:30
@BohuTANG
Copy link
Member

BohuTANG commented Jan 12, 2024

Convert to draft, let's wait some tools(generate parquet files, which will be COPY by Databend) from parquet2 to parquet-rs.

@sundy-li sundy-li marked this pull request as ready for review February 29, 2024 03:14
@sundy-li
Copy link
Member Author

@BohuTANG It's ready to continue. Both are already compatible, I don't want to solve lots of conflicts weeks later.

@BohuTANG BohuTANG merged commit c54890d into datafuselabs:main Feb 29, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants