Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(planner): refine cascades optimizer #14350

Merged
merged 1 commit into from Jan 17, 2024
Merged

chore(planner): refine cascades optimizer #14350

merged 1 commit into from Jan 17, 2024

Conversation

leiysky
Copy link
Member

@leiysky leiysky commented Jan 16, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Executing task in-place until it's blocked to reduce scheduling overhead.
  • Support cost lower bound pruning
  • Minor refactor of SharedCounter

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 16, 2024
@leiysky leiysky force-pushed the refine-cascades branch 3 times, most recently from 703d4c3 to 2b701f1 Compare January 17, 2024 05:56
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Jan 17, 2024
@leiysky leiysky added this pull request to the merge queue Jan 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-14350-a968c59

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

cloud cloud

ClickBench Report

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2024
@leiysky leiysky added this pull request to the merge queue Jan 17, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 17, 2024
@BohuTANG BohuTANG merged commit b477e99 into datafuselabs:main Jan 17, 2024
82 checks passed
@leiysky leiysky deleted the refine-cascades branch January 17, 2024 14:27
Xuanwo pushed a commit to Xuanwo/databend that referenced this pull request Jan 19, 2024
@leiysky @Xuanwo
chore(planner): refine cascades optimizer (datafuselabs#14350)
5579335 
refine cascades optimizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leiysky @andylokandy @BohuTANG