feat: Remove the need of setting allow_anonymous #14398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
github-actions
bot
added
the
pr-feature
|
cc @soyeric128, we don't need to set |
drmingdrmer
reviewed
Jan 22, 2024
There was a problem hiding this comment.
A test should still be added to ensure future version of query can read protobuf message of this version.
Reviewed 10 of 12 files at r1, all commit messages.
Reviewable status: 10 of 12 files reviewed, all discussions resolved
Signed-off-by: Xuanwo <github@xuanwo.io>
drmingdrmer
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
LGTM!
Reviewed 2 of 12 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Xuanwo)
|
Uni test failed: |
yufan022
pushed a commit
to yufan022/databend
that referenced
this pull request
Feb 2, 2024
* feat: Remove the need of setting allow_anonymous Signed-off-by: Xuanwo <github@xuanwo.io> * Add test Signed-off-by: Xuanwo <github@xuanwo.io> * Fix test Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io>
yufan022
added a commit
to yufan022/databend
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR will remove the need to set allow_anonymous. Make it much simple to access public bucket.
Tests
Type of change
This change is