Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make cost factor configurable #14445

Merged
merged 1 commit into from Jan 24, 2024
Merged

chore: make cost factor configurable #14445

merged 1 commit into from Jan 24, 2024

Conversation

leiysky
Copy link
Member

@leiysky leiysky commented Jan 24, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Introduce some settings to configure the cost factors.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 24, 2024
@leiysky leiysky disabled auto-merge January 24, 2024 12:06
@BohuTANG BohuTANG merged commit 53a41aa into datafuselabs:main Jan 24, 2024
73 checks passed
@leiysky leiysky deleted the cost-factor branch January 24, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@andylokandy andylokandy andylokandy approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leiysky @BohuTANG @andylokandy