Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: only wrap logical get with distinct to eliminate duplicates rows for subquery in single mode #14452

Merged
merged 1 commit into from Jan 24, 2024
Merged

chore: only wrap logical get with distinct to eliminate duplicates rows for subquery in single mode #14452

merged 1 commit into from Jan 24, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Jan 24, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

to avoid agg shuffle under cluster mode.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 24, 2024
@xudong963 xudong963 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into datafuselabs:main with commit 3ccec47 Jan 24, 2024
73 checks passed
@xudong963 xudong963 deleted the cluster_agg branch January 24, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xudong963 @Dousir9