Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support window function in subquery #14518

Merged
merged 3 commits into from Jan 31, 2024
Merged

feat: support window function in subquery #14518

merged 3 commits into from Jan 31, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Jan 30, 2024 •
edited

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

support window function in subquery

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 marked this pull request as draft January 30, 2024 07:35
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 30, 2024
@xudong963 xudong963 marked this pull request as ready for review January 30, 2024 14:27
ariesdevil
ariesdevil approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit 8dbc11c into datafuselabs:main Jan 31, 2024
71 checks passed
@xudong963 xudong963 deleted the window_subquery branch January 31, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariesdevil ariesdevil ariesdevil approved these changes

@Dousir9 Dousir9 Dousir9 approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xudong963 @ariesdevil @Dousir9 @BohuTANG