New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): agg-hashtable-singleton #14524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Jan 30, 2024
Better to give a benchmark results rather than a summary :) |
Benchmark script:
|
Docker Image for PR
|
small:
This table now includes the total sum for each column at the bottom. |
sundy-li
approved these changes
Feb 1, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-cloud
Build docker image for cloud test
pr-feature
this PR introduces a new feature to the codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Introduce agg hashtable in the query pipeline and support partition ht.
In this PR, after running ClickBench, we observed improved performance for most queries, the remaining performance is similar to main. We also run ClickBench in DuckDB in the same environment, and the performance was similar.
We can enable this via : set enable_experimental_aggregate_hashtable = 1;
Note this pr only works in singleton deployment currently.
Pros:
better performance in high cardinality group aggregation, up to 2x
better performance in group by string column
better and cleaner codes than the old one
Cons:
It may consume more memory usage than the old one cause it uses using two-part struct layout
continue #13548
Tests
Type of change
This change is