Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime filters add to wrong table #14552

Merged
merged 2 commits into from Feb 1, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Feb 1, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Make each probe key attach to its corresponding tables. The table will be used as the target table to add runtime filters.

For example:

Right side is the build side, t1 will have runtime filter due to the bottom of join and t2 will have runtime filter due to the top of join.

       join(t2.c = t3.c)
      /   \
     /    t3
join(t1.a = t2.b)
   /  \
  t1   t2
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - covered by current tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 1, 2024
@xudong963 xudong963 added this pull request to the merge queue Feb 1, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 1, 2024
@BohuTANG BohuTANG merged commit 9f62443 into datafuselabs:main Feb 1, 2024
71 checks passed
@xudong963 xudong963 deleted the refactor_table_index_for_rf branch February 1, 2024 14:10
yufan022 pushed a commit to yufan022/databend that referenced this pull request Apr 25, 2024
* fix: runtime filters add to wrong table

* refine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants