Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine plan id generation #14644

Merged
merged 2 commits into from Feb 8, 2024
Merged

Conversation

leiysky
Copy link
Member

@leiysky leiysky commented Feb 7, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Generate plan id in top-down sequence, which means the parent plans will have smaller plan id.

Before this PR:

Join_2
    Scan_0
    Scan_1

With this PR:

Join_0
    Scan_1
    Scan_2

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 7, 2024
@leiysky leiysky marked this pull request as draft February 7, 2024 11:50
@leiysky leiysky marked this pull request as ready for review February 7, 2024 12:47
@zhang2014 zhang2014 added this pull request to the merge queue Feb 8, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 8, 2024
@BohuTANG BohuTANG merged commit aa03893 into datafuselabs:main Feb 8, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants