Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support vacuum temporary files #14690

Merged
merged 11 commits into from Feb 23, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Feb 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(query): support vacuum temporary files

Syntax: 
VACUUM TEMPORARY FILES [RETAIN \<number\> SECONDS|DAYS] [LIMIT \<number\>]; 
    RETAIN: temporary files exceeding this time range will be deleted.
    LIMIT: the maximum number of files to be deleted in this operation. helps for situations where there are too many temporary files.
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 20, 2024
@zhang2014 zhang2014 marked this pull request as ready for review February 22, 2024 08:08
@BohuTANG
Copy link
Member

Better to introcude the full sytax of the new feature, it's helpful to write document.

@zhang2014
Copy link
Member Author

Better to introcude the full sytax of the new feature, it's helpful to write document.

Done. CC: @soyeric128

Copy link
Collaborator

@lichuang lichuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to add some unit test cases like in src/query/ee/tests/it/storages/fuse/operations/vacuum.rs

Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Privilege part is LGTM

@zhang2014
Copy link
Member Author

it is better to add some unit test cases like in src/query/ee/tests/it/storages/fuse/operations/vacuum.rs

Done.

@sundy-li sundy-li added this pull request to the merge queue Feb 23, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 23, 2024
@BohuTANG BohuTANG merged commit 11ee029 into datafuselabs:main Feb 23, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants