Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor refactor of adjust_bloom_runtime_filter #14697

Merged
merged 2 commits into from Feb 21, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Feb 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Check the setting of enable_bloom_runtime_filter firstly in adjust_bloom_runtime_filter.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 20, 2024
@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label Feb 20, 2024
@BohuTANG BohuTANG merged commit 513555a into datafuselabs:main Feb 21, 2024
71 checks passed
@xudong963 xudong963 deleted the chore_bloom branch February 21, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants