Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): filter response session settings with ScopeLevel::Session #14702

Merged
merged 2 commits into from Feb 22, 2024
Merged

fix(query): filter response session settings with ScopeLevel::Session #14702

merged 2 commits into from Feb 22, 2024

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Feb 21, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 21, 2024
@everpcpc everpcpc marked this pull request as draft February 21, 2024 08:32
@everpcpc everpcpc changed the title fix(query): do not filter default value for response session fix(query): filter response session settings with ScopeLevel::Session Feb 21, 2024
@everpcpc everpcpc marked this pull request as ready for review February 21, 2024 09:17
@sundy-li
Copy link
Member

need test cases

@everpcpc everpcpc merged commit c9f680a into datafuselabs:main Feb 22, 2024
71 checks passed
@everpcpc everpcpc deleted the fix-setting branch February 22, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: settings can't change back to default value after global set
3 participants
@everpcpc @sundy-li @zhang2014