Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): improve new filter execution #14715

Merged

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Feb 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

When advancing PR #14689, it was found that the performance of the filter could be improved: when the comparison function is used as a return value, its #[inline(always)] will be ignored, after fixing this issue, the execution of the filter can be accelerated by ~ 40%

FlameGraph

Q1 filter before
截屏2024-02-22 20 04 13

Q1 filter after
截屏2024-02-22 20 04 45

Q3 filter before
截屏2024-02-22 20 06 40

Q3 filter after
截屏2024-02-22 20 07 05

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Covered by existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 22, 2024
@Dousir9 Dousir9 marked this pull request as ready for review February 22, 2024 14:12
@Dousir9 Dousir9 added this pull request to the merge queue Feb 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 23, 2024
@Dousir9 Dousir9 added this pull request to the merge queue Feb 23, 2024
Merged via the queue into datafuselabs:main with commit bbcd702 Feb 23, 2024
71 checks passed
@Dousir9 Dousir9 deleted the improve_new_filter_execution_framework branch February 23, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants