chore(query): improve new filter execution #14715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
When advancing PR #14689, it was found that the performance of the filter could be improved: when the comparison function is used as a return value, its
#[inline(always)]
will be ignored, after fixing this issue, the execution of the filter can be accelerated by ~ 40%FlameGraph
Q1 filter before
Q1 filter after
Q3 filter before
Q3 filter after
Tests
Type of change
This change is