Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metrics for compact and recluster #14717

Merged
merged 2 commits into from Feb 23, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Feb 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • new metrics

    • fuse_compact_block_build_lazy_part_milliseconds (histogram)
    • fuse_recluster_build_task_milliseconds (histo)
    • fuse_recluster_segment_nums_scheduled (counter)
  • While selecting the blocks with the highest depth

    segments no longer processed one by one, multiple segments might be squashed into one unit for selection, if the number of blocks of these segments reaches the value of setting FUSE_OPT_KEY_BLOCK_PER_SEGMENT.

  • tweak(fix) the logic of ReclusterMutator::segment_can_recluster

    the segment will be a candidate for recluster, only if it does not consist of constant blocks(only), or the number of blocks does not reach the value of setting FUSE_OPT_KEY_BLOCK_PER_SEGMENT.

  • adjusted log messages for clarity and precision.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 22, 2024
@dantengsky
Copy link
Member

@zhyass PR summary has been updated, please have a look

@dantengsky dantengsky added this pull request to the merge queue Feb 23, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 23, 2024
@BohuTANG BohuTANG merged commit f52351b into datafuselabs:main Feb 23, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants