Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Transaction state is not changed correctly when returning error in commit statement #14824

Merged
merged 9 commits into from Mar 5, 2024
Merged

fix: Transaction state is not changed correctly when returning error in commit statement #14824

merged 9 commits into from Mar 5, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Mar 4, 2024 •
edited

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • Long run

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@SkyFan2002 SkyFan2002 changed the title Fix: Transaction state is not changed correctly when returning error in commit statement fix: Transaction state is not changed correctly when returning error in commit statement Mar 4, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 4, 2024
@dantengsky dantengsky added this pull request to the merge queue Mar 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2024
@SkyFan2002 SkyFan2002 added this pull request to the merge queue Mar 5, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 5, 2024
@BohuTANG BohuTANG merged commit f265159 into datafuselabs:main Mar 5, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@youngsofun youngsofun youngsofun approved these changes

@dantengsky dantengsky dantengsky approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SkyFan2002 @BohuTANG @youngsofun @dantengsky