fix: check_and_upgrade_to_pb() should return MetaError, add quota
#14899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmingdrmer
force-pushed
the
37-upgrade-setting-to-pb
branch
2 times, most recently
from
ae767bb
to
07def2c
Compare
TCeason
approved these changes
Mar 11, 2024
When writing back upgraded json-to-pb data to meta-service, it should return `MetaError`, instead of business error such as `ErrorCode::UnknownRole`. Add quota limit to `check_and_upgrade_to_pb`: for each API calls, it upgrades upto 100 records. So that an API call won't be delay a lot. After upgrading, it should returns the `seq` number after upgrading.
drmingdrmer
force-pushed
the
37-upgrade-setting-to-pb
branch
from
07def2c
to
d0fb8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fix:
check_and_upgrade_to_pb()should return MetaError, add quotaWhen writing back upgraded json-to-pb data to meta-service,
it should return
MetaError, instead of business error such asErrorCode::UnknownRole.Add quota limit to
check_and_upgrade_to_pb: for each API calls, itupgrades upto 100 records. So that an API call won't be delay a lot.
After upgrading, it should returns the
seqnumber after upgrading.Changelog
Related Issues
This change is