Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support settings admin api for global level settings #14901

Merged
merged 2 commits into from Mar 11, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Mar 11, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(query): support settings admin api for global level settings

curl -XGET 'http://127.0.0.1:8080/v1/tenants/test_tenant/settings'    
curl -XPOST 'http://127.0.0.1:8080/v1/tenants/test_tenant/settings/max_threads' -H "Content-Type: application/json" --data "\"2\""
curl -XDELETE 'http://127.0.0.1:8080/v1/tenants/test_tenant/settings/max_threads'
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 11, 2024
@zhang2014 zhang2014 force-pushed the feat/settings_api branch 2 times, most recently from 9de3d31 to a49c04c Compare March 11, 2024 07:07
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @youngsofun Maybe should have a look.

@zhang2014 zhang2014 added this pull request to the merge queue Mar 11, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 11, 2024
@BohuTANG BohuTANG merged commit 1ee4707 into datafuselabs:main Mar 11, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants