Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use kvapi::Key to define meta-service key for QuotaMgr #14915

Merged
merged 2 commits into from Mar 12, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Mar 12, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: use kvapi::Key to define meta-service key for QuotaMgr

Changelog

  • Improvement

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 12, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review March 12, 2024 05:50
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW, get_network_policy_api_client rename to tenant_quota_api. So in the future, get_xx_api_client needs to do the same refactor?

get_xx_api_client -> xx_api? E.G. get_network_policy_api_client, get_password_policy_api_client

@drmingdrmer
Copy link
Member Author

LGTM.

BTW, get_network_policy_api_client rename to tenant_quota_api. So in the future, get_xx_api_client needs to do the same refactor?

get_xx_api_client -> xx_api? E.G. get_network_policy_api_client, get_password_policy_api_client

Yes. get_network_policy_api_client is too long to me. xxx_api` tells enough about what it does.

@drmingdrmer drmingdrmer merged commit f248f21 into datafuselabs:main Mar 12, 2024
71 checks passed
@drmingdrmer drmingdrmer deleted the 21-quota-kvapi-key branch March 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants