Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support prql #14922

Merged
merged 3 commits into from Mar 18, 2024
Merged

feat: support prql #14922

merged 3 commits into from Mar 18, 2024

Conversation

ncuwaln
Copy link
Contributor

@ncuwaln ncuwaln commented Mar 12, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

support prql in databend
#14811

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 12, 2024
@sundy-li
Copy link
Member

could we support this inside the ast crate ?

@ncuwaln
Copy link
Contributor Author

ncuwaln commented Mar 13, 2024

could we support this inside the ast crate ?

Ast crate use tokens as parameter now, but prql's token not same as databend sql’s token. so if we want to support this inside ast, maybe we need make string as ast parser's parameter?

@sundy-li
Copy link
Member

Ast crate use tokens as parameter now, but prql's token not same as databend sql’s token. so if we want to support this inside ast, maybe we need make string as ast parser's parameter?

I see now, this pr's approach is ok.

@sundy-li
Copy link
Member

Good to me, let's add some tests.

@ncuwaln ncuwaln marked this pull request as ready for review March 18, 2024 06:18
@ncuwaln
Copy link
Contributor Author

ncuwaln commented Mar 18, 2024

Good to me, let's add some tests.

done

@sundy-li sundy-li added this pull request to the merge queue Mar 18, 2024
Merged via the queue into datafuselabs:main with commit e4e0ebe Mar 18, 2024
75 checks passed
@snth
Copy link

snth commented Mar 18, 2024

Thank you!

@max-sixty
Copy link

Hi from the PRQL team! Excited to see this.

If you'd like to add links to Databend from our website & docs, please feel free to. We did this for ClickHouse when they started supporting PRQL, so we could pretty much copy that PR..

@sundy-li
Copy link
Member

If you'd like to add links to Databend from our website & docs, please feel free to

@ncuwaln Could you send a pr to improve the PRQL's website?

BTW @max-sixty we will write a blog about PRQL with Databend soon.

@ncuwaln
Copy link
Contributor Author

ncuwaln commented Mar 19, 2024

@ncuwaln Could you send a pr to improve the PRQL's website?

Of course, i will send a pr soon

@ncuwaln
Copy link
Contributor Author

ncuwaln commented Mar 23, 2024

Of course, i will send a pr soon

I will send a pr after databend doc ready

@sundy-li
Copy link
Member

document cc @soyeric128

@soyeric128
Copy link
Collaborator

Prql is missing:

Screenshot 2024-03-25 at 6 12 45 PM

@ncuwaln
Copy link
Contributor Author

ncuwaln commented Mar 26, 2024

Prql is missing:

Already send a pr to fix it

#15091

@SkyFan2002 SkyFan2002 mentioned this pull request Mar 29, 2024
16 tasks
@sundy-li
Copy link
Member

sundy-li commented Apr 3, 2024

A blog about databend & prql: https://www.databend.com/blog/2024-04-03-databend-integrates-prql/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants