Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tweak txn syntax #14960

Merged
merged 1 commit into from Mar 15, 2024
Merged

chore: tweak txn syntax #14960

merged 1 commit into from Mar 15, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Mar 15, 2024 •
edited by dantengsky

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Add an optional "TRANSACTION" clause, for the begin statement:

begin [transaction]
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 15, 2024
@SkyFan2002 SkyFan2002 marked this pull request as ready for review March 15, 2024 05:35
@dantengsky dantengsky added this pull request to the merge queue Mar 15, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 15, 2024
@BohuTANG BohuTANG merged commit e807a73 into datafuselabs:main Mar 15, 2024
87 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SkyFan2002 @dantengsky @BohuTANG