Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): tune log on getting /v1/query/:id/kill #14987

Merged
merged 2 commits into from Mar 20, 2024

Conversation

flaneur2020
Copy link
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

this pr made a small modificaton on logs, make it more clear about what is actually happening.

Tests

  • No Test - log text modification

Type of change

  • Other (please describe): small log modification

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 18, 2024
@flaneur2020 flaneur2020 marked this pull request as draft March 18, 2024 03:41
@flaneur2020 flaneur2020 marked this pull request as ready for review March 18, 2024 03:56
@BohuTANG
Copy link
Member

error: 2 positional arguments in format string, but there is 1 argument
   --> src/query/service/src/servers/http/v1/http_query_handlers.rs:220:14
    |
220 |             "{}: got /v1/query/{}/final request, this query is going to be finally completed.",
    |              ^^                ^^
221 |             query_id
    |             --------

error: could not compile `databend-query` (lib) due to 1 previous error

@BohuTANG BohuTANG merged commit f281dc3 into datafuselabs:main Mar 20, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants