Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a setting for inlist to join #15024

Merged
merged 1 commit into from Mar 19, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Mar 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

for now, the inlist needs to over 1024, so we can change it into join, we add a setting in this pr for user to adjust it.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 19, 2024
@JackTan25
Copy link
Collaborator

if we can add a test for this, it will be better. But it doesn't matter.

@JackTan25 JackTan25 added this pull request to the merge queue Mar 19, 2024
Merged via the queue into datafuselabs:main with commit 25dbf81 Mar 19, 2024
82 of 84 checks passed
@xudong963 xudong963 deleted the list_to_join_threshold branch March 19, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants