Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default enable aggregate/sort/join spill #15038

Merged
merged 2 commits into from Mar 20, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Mar 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR default enable spill in the settings:

  1. join_spilling_memory_ratio=60
  2. aggregate_spilling_memory_ratio=60
  3. sort_spilling_memory_ratio=60
  4. Add test for the spill enabled e9b5f2e
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Exists Tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 20, 2024
@BohuTANG BohuTANG marked this pull request as ready for review March 20, 2024 07:10
@BohuTANG BohuTANG force-pushed the dev-joinspill-enable branch 2 times, most recently from 1feb20c to ac1c32d Compare March 20, 2024 08:43
@BohuTANG BohuTANG merged commit 4a55ea4 into datafuselabs:main Mar 20, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants