Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): implement st_makeline() function #15059

Merged
merged 10 commits into from
Mar 26, 2024
Merged

feat(query): implement st_makeline() function #15059

merged 10 commits into from
Mar 26, 2024

Conversation

kkk25641463
Copy link
Contributor

@kkk25641463 kkk25641463 commented Mar 21, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Support snowflake st_makeline(geometry, geometry) function.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@kkk25641463 kkk25641463 changed the title implement st_makeline() function feat(query): implement st_makeline() function Mar 21, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 21, 2024
@kkk25641463
Copy link
Contributor Author

I had already add srid logic and unit test.

@ariesdevil
Copy link
Collaborator

I had already add srid logic and unit test.

Plz run make lint make the ci happy

@kkk25641463
Copy link
Contributor Author

I had already add srid logic and unit test.

Plz run make lint make the ci happy
Sorry, I'm not familiar with databend pr workflow.I'll fix it right now.

ariesdevil
ariesdevil approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@ariesdevil ariesdevil added this pull request to the merge queue Mar 26, 2024
Merged via the queue into datafuselabs:main with commit 9c50ece Mar 26, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariesdevil ariesdevil ariesdevil approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkk25641463 @ariesdevil