Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Tenant::new_literal() and new_nonempty() to avoid creating empty Tenant #15061

Merged
merged 2 commits into from Mar 21, 2024
Merged

chore: use Tenant::new_literal() and new_nonempty() to avoid creating empty Tenant #15061

merged 2 commits into from Mar 21, 2024

Conversation

drmingdrmer
Copy link
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore: use Tenant::new_literal() and new_nonempty() to avoid creating empty Tenant
chore: add comment

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 21, 2024
@drmingdrmer drmingdrmer mentioned this pull request Mar 21, 2024
Open
29 tasks
@drmingdrmer drmingdrmer marked this pull request as ready for review March 21, 2024 14:40
@drmingdrmer drmingdrmer merged commit beb5d38 into datafuselabs:main Mar 21, 2024
75 checks passed
@drmingdrmer drmingdrmer deleted the 21-non-empty branch March 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drmingdrmer @TCeason