Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix attach_query_str #15066

Merged
merged 7 commits into from Mar 23, 2024
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Mar 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. fix attach_query_str, now it's injected after the parser
    2. remove unused ParquetTableForCopy
  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 22, 2024
@BohuTANG
Copy link
Member

Does this PR also fix this issue? #15065

@sundy-li
Copy link
Member Author

Does this PR also fix this issue? #15065

No, query log is written inside interpreter.

@BohuTANG BohuTANG merged commit 9399794 into datafuselabs:main Mar 23, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants