Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ast): fix incorrect display for ast (part 1) #15069

Merged
merged 13 commits into from Mar 23, 2024

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Mar 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Related #14904

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 22, 2024
@SkyFan2002
Copy link
Member

May I ask how can we determine if the SQL generated by Display is equivalent to the original SQL? This has troubled me for a long time.

@andylokandy
Copy link
Collaborator Author

andylokandy commented Mar 22, 2024

An ideal display will satisfy two rules: 1. The display string contains all information in the original sql, despite of formatting difference; 2. Reparse the displayed string and then display it again should come out with the identical sql.

In this PR, I'll add a check for the second rule.

@SkyFan2002
Copy link
Member

An ideal display will satisfy two rules: 1. The display string contains all information in the original sql, despite of formatting difference; 2. Reparse the displayed string and then display it again should come out identical sql.

In this PR, I'll add a check for the second rule.

Thanks. The second rule is brilliant.

@andylokandy andylokandy marked this pull request as ready for review March 23, 2024 06:36
@andylokandy andylokandy changed the title fix(ast): fix incorrect display for ast fix(ast): fix incorrect display for ast (part 1) Mar 23, 2024
@andylokandy andylokandy added this pull request to the merge queue Mar 23, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 23, 2024
@BohuTANG BohuTANG merged commit 18167a1 into datafuselabs:main Mar 23, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants