Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test duplicate in window_basic.test #15100

Merged
merged 1 commit into from Mar 27, 2024
Merged

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Mar 27, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

test duplicate in window_basic.test

Perhaps it would be better to have only one identical copy of the test in the test file.

screenshot-20240327-100558
screenshot-20240327-100534
screenshot-20240327-100503

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 27, 2024
@BohuTANG BohuTANG requested a review from sundy-li March 27, 2024 02:55
@BohuTANG BohuTANG merged commit d4ff2f0 into datafuselabs:main Mar 27, 2024
72 checks passed
@c8ef c8ef deleted the c8ef-patch-2 branch April 2, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants